Fix ASCII function and groom UT for text functions. (#301)
#1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix `ASCII` function and groom UT for text functions. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Code cleanup. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1895 +/- ##
=========================================
Coverage 97.52% 97.52%
- Complexity 4655 4656 +1
=========================================
Files 408 408
Lines 11952 11953 +1
Branches 829 830 +1
=========================================
+ Hits 11656 11657 +1
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matthewryanwells
approved these changes
Jul 24, 2023
GumpacG
previously approved these changes
Jul 25, 2023
acarbonetto
previously approved these changes
Aug 17, 2023
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
dismissed stale reviews from acarbonetto and GumpacG
via
82a333f
GumpacG
approved these changes
Aug 18, 2023
MitchellGale
approved these changes
Aug 18, 2023
acarbonetto
approved these changes
Aug 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
* Fix `ASCII` function and groom UT for text functions. * Code cleanup. --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 6055c7e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Aug 24, 2023
…2029) * Fix `ASCII` function and groom UT for text functions. * Code cleanup. --------- (cherry picked from commit 6055c7e) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
ASCIIfunction (to return 0 for empty string, see doc)BEFORE
AFTER
Update UT for all text functions (similar to #1310):
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.